Topic on User talk:Harakoni

Corrected

Hi Harakoni,

I noticed there is a small error in the dps calculations of melee weapons (at least with the Persona Zeushammer and Longsword, but I assume it is also the case with other melee weapons).

With melee weapons, it currently has the assumption that every attack takes the same amount of time. Take the Persona Zeushammer with normal quality for example. In the quality table it shows an average DPS of 12.91 (and an average AP of 40%). The attack with the handle takes 1.6 seconds, dealing 15 damage and is chosen 25% of the time. The attack with the head takes 2.2 seconds and deals 31 damage. This one is chosen 75% of the time.

It seems that currently the following formula is used for calculations: (bestDamage/bestCooldownTime)*bestSelectionWeight + (midDamage/midCooldownTime)*midSelectionWeight = DPS.

For the normal quality Persona Zeushammer this translates to the following:

((31 / 2.2) * 0.75) + ((15 / 1.6) * 0.25) = 12.91 DPS.

However, a more accurate formula would be: (bestDamage*bestSelectionWeight + midDamage*midSelectionWeight) / (bestCooldownTime*bestSelectionWeight + midCoolDownTime*midSelectionWeight) = DPS.

This takes the duration of the cooldown of the attack into account. For the normal quality Persona Zeushammer this translates to the following:

(31 * 0.75 + 15 * 0.25) / (2.2 * 0.75 + 1.6 * 0.25) = 13.17 DPS.

I hope this explaination helps!

Derp. You are totally right. I can't believe I missed that. Implementing changes now. Thank you.

Done. Can you do me a favor and check a couple of weapons again? Let me know if I missed anything else or if I screwed up my implementation?

You might need to Refresh the page under the "More" option in the top right of the page to make sure the template has been updated. Really appreciate you taking the time to let me know btw.

I checked a couple and those had the correct values now (at least for dps, I did not check average AP). Thanks for making the changes!